Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Smime::verifyPassphrase compatibe with php8 #11

Open
wants to merge 1 commit into
base: FRAMEWORK_6_0
Choose a base branch
from
Open

make Smime::verifyPassphrase compatibe with php8 #11

wants to merge 1 commit into from

Conversation

midahp
Copy link

@midahp midahp commented Jun 24, 2024

openssl_pkey_get_private returns an instance of OpenSSLAsymmetricKey in php8. So we can't use is_resource anymore to check if it was successfull.

This still works with php74, since boolval($someResource) is always true.

@midahp midahp marked this pull request as draft June 24, 2024 14:08
@midahp midahp marked this pull request as ready for review June 26, 2024 07:16
@midahp
Copy link
Author

midahp commented Jun 27, 2024

@ralflang can you maybe take a look at this this small PR?
If you merge it, can you also make a new release for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@midahp