Ensure LastError exception only passes integers

As of PHP 8.1, null can no longer be passed to the second constructor argument of builtin exceptions. It will raise an error, resulting in log spam. Found executing the test suite of horde/yaml in php 8.1
horde · Aug 19, 2022 · 15b6109 · 15b6109
1 parent 754c7a3
commit 15b6109
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/Horde/Exception/LastError.php b/lib/Horde/Exception/LastError.php
@@ -48,7 +48,7 @@ public function __construct($message = null, $code_or_lasterror = null)
             $this->file = $code_or_lasterror['file'];
             $this->line = $code_or_lasterror['line'];
         } else {
-            parent::__construct($message, $code_or_lasterror);
+            parent::__construct($message, $code_or_lasterror ?? 0);
         }
     }
 

diff --git a/lib/Horde/Exception/PermissionDenied.php b/lib/Horde/Exception/PermissionDenied.php
@@ -27,7 +27,7 @@ class Horde_Exception_PermissionDenied extends Horde_Exception
      *
      * @see Horde_Exception::__construct()
      *
-     * @param mixed $message           The exception message, a PEAR_Error
+     * @param string|Exception $message           The exception message, a PEAR_Error
      *                                 object, or an Exception object.
      * @param integer $code            A numeric error code.
      */