Skip to content

Commit

Permalink
Revert "Don't add empty notes."
Browse files Browse the repository at this point in the history
package.xml must not contain empty <notes> tags.

This reverts commit 4605337.
  • Loading branch information
yunosh committed Oct 27, 2017
1 parent c983efd commit 6624e9d
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions lib/Horde/Pear/Package/Xml.php
Expand Up @@ -469,11 +469,9 @@ public function setNotes(array $notes)
{
$thisVersion = $this->getVersion();
foreach ($notes as $version => $info) {
$new_notes = implode("\n* ", explode("\n", trim($info['notes'])));
if ($new_notes) {
$new_notes = "\n* " . $new_notes;
}
$new_notes .= "\n ";
$new_notes = "\n* "
. implode("\n* ", explode("\n", trim($info['notes'])))
. "\n ";
if ($version == $thisVersion) {
$this->replaceTextNode('/p:package/p:notes', $new_notes);
}
Expand Down

0 comments on commit 6624e9d

Please sign in to comment.