Rebuild complete changelog in setNotes().

horde · Dec 11, 2017 · 76465b8 · 76465b8
1 parent 56d7676
commit 76465b8
Showing 1 changed file with 11 additions and 13 deletions.
diff --git a/lib/Horde/Pear/Package/Xml.php b/lib/Horde/Pear/Package/Xml.php
@@ -468,26 +468,24 @@ public function addNote($note)
     public function setNotes(array $notes)
     {
         $thisVersion = $this->getVersion();
+        foreach ($this->findNodes('/p:package/p:changelog/p:release') as $release) {
+            $this->removeWhitespace($release->previousSibling);
+            $release->parentNode->removeChild($release);
+        }
         foreach ($notes as $version => $info) {
             $new_notes = "\n* "
                 . implode("\n* ", explode("\n", trim($info['notes'])))
                 . "\n ";
             if ($version == $thisVersion) {
                 $this->replaceTextNode('/p:package/p:notes', $new_notes);
             }
-            if ($node = $this->_fetchRelease($version)) {
-                $this->replaceTextNodeRelativeTo(
-                    './p:notes', $node, $new_notes . '  '
-                );
-            } elseif (isset($info['date'])) {
-                $this->addVersion(
-                    $version, $info['api'],
-                    $info['state']['release'], $info['state']['api'],
-                    $info['date'],
-                    $info['license']['identifier'], $info['license']['uri'],
-                    $new_notes
-                );
-            }
+            $this->addVersion(
+                $version, $info['api'],
+                $info['state']['release'], $info['state']['api'],
+                $info['date'],
+                $info['license']['identifier'], $info['license']['uri'],
+                $new_notes
+            );
         }
     }