Add TLS1.3 stream option

[ChristophWurst]

Discovered in nextcloud/mail#3368 (comment).

@mrubinsk hope this is ok. Do we need a check around this? I saw that STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT doesn't have one either so I just added the constant. Let me know what you prefer.

[mrubinsk]

@ChristophWurst TLS 1.3 (and that constant) are only supported starting with PHP 7.4 from the looks of it so we can't use it bare like that.

According to the php source (https://github.com/php/php-src/blob/PHP-7.4.0/main/streams/php_stream_transport.h#L176), it looks like the existing STREAM_CRYPTO_METHOD_TLS_CLIENT actually already includes all of the TLS versions in PHP 7.4 as well. So we can probably just use that constant and get of the OR's in the case of PHP 7.4.

[ChristophWurst]

According to the php source (https://github.com/php/php-src/blob/PHP-7.4.0/main/streams/php_stream_transport.h#L176), it looks like the existing STREAM_CRYPTO_METHOD_TLS_CLIENT actually already includes all of the TLS versions in PHP 7.4 as well. So we can probably just use that constant and get of the OR's in the case of PHP 7.4.

7.2 in fact: https://github.com/php/php-src/blob/PHP-7.2.0/main/streams/php_stream_transport.h#L176. I'll change it to that.

[ChristophWurst]

@mrubinsk please let me know if the changes are OK or if you with to have it done differently ✌️

[mrubinsk]

@ChristophWurst Yup, looks good. I'll merge this as soon as I have some time.

[yunosh]

This wouldn't work with PHP < 5.6 which we unfortunately still support. How about using:
STREAM_CRYPTO_METHOD_TLS_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_0_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT | STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT
if STREAM_CRYPTO_METHOD_TLSv1_0_CLIENT exists and STREAM_CRYPTO_METHOD_TLS_CLIENT if not. Wouldn't this cover all cases?

[jstark1]

I still hope the PR will be merged. Is there any progress here?

[mrubinsk]

Apologies, this fell through the cracks. I had thought I committed this already.