Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for upcoming PHP 7.4 #2

Merged
merged 2 commits into from Nov 2, 2019
Merged

Fixes for upcoming PHP 7.4 #2

merged 2 commits into from Nov 2, 2019

Conversation

remicollet
Copy link
Contributor

Running Horde_Data test suite with 7.4.0RC3

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.0RC3
Configuration: /dev/shm/BUILD/php-horde-Horde-Data-2.1.4/Horde_Data-2.1.4/test/Horde/Data/phpunit.xml

E............                                                     13 / 13 (100%)

Time: 24 ms, Memory: 4.00MB

There was 1 error:

1) Horde_Data_CsvTest::testImportFile
Function get_magic_quotes_gpc() is deprecated

/usr/share/pear/Horde/Util.php:117
/usr/share/pear/Horde/Variables.php:73
/usr/share/pear/Horde/Variables.php:57
/dev/shm/BUILD/php-horde-Horde-Data-2.1.4/Horde_Data-2.1.4/lib/Horde/Data/Base.php:105
/dev/shm/BUILD/php-horde-Horde-Data-2.1.4/Horde_Data-2.1.4/test/Horde/Data/CsvTest.php:14

ERRORS!
Tests: 13, Assertions: 21, Errors: 1.

New warning raised in PHP 7.4
as uniqid generated a hexa string, switch to base 16
@remicollet
Copy link
Contributor Author

Second commit was found in Horde_Prefs test suite

1) Horde_Prefs_Unit_Storage_FileTest::testConstruction
Invalid characters passed for attempted conversion, these have been ignored
/usr/share/pear/Horde/Util.php:307
/builddir/build/BUILD/php-horde-Horde-Prefs-2.9.0/Horde_Prefs-2.9.0/test/Horde/Prefs/Unit/Storage/FileTest.php:48

@remicollet remicollet changed the title Fix Function get_magic_quotes_gpc() is deprecated (7.4) Fixes for upcoming PHP 7.4 Oct 17, 2019
@mrubinsk mrubinsk merged commit c348cb0 into horde:master Nov 2, 2019
ralflang referenced this pull request in maintaina-com/Util Nov 12, 2019
ChristophWurst pushed a commit to ChristophWurst/Horde_Util that referenced this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants