Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
25 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
214ce32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why that?
214ce32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These version numbers were failing validation in Components_Helper_Version::validatePear() when adding new changelog entries (and maybe during release?). Since these are supposed to be Pear-ish version numbers, I took guidance from Pear's examples here: https://pear.php.net/manual/en/guide.users.concepts.version.php and fixed the version numbers rather then fixing the regexp.
214ce32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you have been using the latest Components version from master?
214ce32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With current master, the error doesn't occur during the 'changed' command, but now rather during a release (run with --pretend at the moment):
Fatal Error:
Invalid version number 3.3.4-RC1
In /usr/local/horde/horde/components/lib/Components/Helper/Version.php on line 36