[jan] Fix dynamically updating menu entries with a _target (Bug #14740).

horde · Jan 22, 2018 · 90faea7 · 90faea7
1 parent 84e8251
commit 90faea7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/docs/changelog.yml b/docs/changelog.yml
@@ -40,6 +40,7 @@
     identifier: LGPL-2
     uri: http://www.horde.org/licenses/lgpl
   notes: |
+    [jan] Fix dynamically updating menu entries with a _target (Bug #14740).
     [jan] Check for both the memcache and memcached extensions in test script (Bug #14691).
 5.2.17:
   api: 5.2.0

diff --git a/js/topbar.js b/js/topbar.js
@@ -51,6 +51,9 @@ var HordeTopbar = {
                 active = nodes[root_node].active ? '-active' : '',
                 container = new Element('DIV', { className: nodes[root_node]['class'] });
             elm = new Element('A', { className: 'horde-mainnavi' + active, href: nodes[root_node].url ? nodes[root_node].url : '#' });
+            if (nodes[root_node].target) {
+                elm.writeAttribute('target', nodes[root_node].target);
+            }
             if (nodes[root_node].onclick) {
                 elm.writeAttribute('onclick', nodes[root_node].onclick);
             }