Check if .horde.yml exists and is up-to-date.

horde · Oct 25, 2017 · 2e583cf · 2e583cf
1 parent d742737
commit 2e583cf
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/lib/Components/Component/Source.php b/lib/Components/Component/Source.php
@@ -158,6 +158,10 @@ public function getDocumentOrigin()
      */
     public function updatePackage($action, $options)
     {
+        if (!file_exists($this->getHordeYmlPath())) {
+            throw new Components_Exception($this->getHordeYmlPath() . ' is missing');
+        }
+
         if (!file_exists($this->getPackageXmlPath())) {
             if (!empty($options['theme'])) {
                 $this->getFactory()->createThemePackageFile($this->_directory);
@@ -711,4 +715,14 @@ public function getPackageXmlPath()
     {
         return $this->_directory . '/package.xml';
     }
+
+    /**
+     * Return the path to the .horde.yml file of the component.
+     *
+     * @return string The path to the .horde.yml file.
+     */
+    public function getHordeYmlPath()
+    {
+        return $this->_directory . '/.horde.yml';
+    }
 }
diff --git a/lib/Components/Helper/ChangeLog.php b/lib/Components/Helper/ChangeLog.php
@@ -135,8 +135,11 @@ public function changelogFileExists()
     public function addChangelog($entry)
     {
         $hordeInfo = $this->_getHordeInfo();
-        $changelog = Horde_Yaml::loadFile($this->_directory . self::CHANGELOG);
+        if (!isset($hordeInfo['version'])) {
+            throw new Components_Exception('.horde.yml is missing a \'version\' entry');
+        }
         $version = $hordeInfo['version']['release'];
+        $changelog = Horde_Yaml::loadFile($this->_directory . self::CHANGELOG);
         $info = $changelog[$version];
         $notes = explode("\n", trim($info['notes']));
         array_unshift($notes, $entry);
@@ -324,8 +327,11 @@ public function updateChanges($options)
             return;
         }
 
-        $hordeInfo = $this->_getHordeInfo();
         $allchanges = Horde_Yaml::loadFile($changelog);
+        $hordeInfo = $this->_getHordeInfo();
+        if (!isset($hordeInfo['version'])) {
+            throw new Components_Exception('.horde.yml is missing a \'version\' entry');
+        }
 
         if (empty($options['pretend'])) {
             $changesfp = fopen($changes, 'w');