Fix with empty release notes.

horde · Oct 25, 2017 · 349772e · 349772e
1 parent b130085
commit 349772e
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/lib/Components/Helper/ChangeLog.php b/lib/Components/Helper/ChangeLog.php
@@ -159,6 +159,14 @@ public function migrateToChangelogYml($xml)
                 'p:version/p:release', $release
             );
             $license = $xml->findNodeRelativeTo('p:license', $release);
+            $notes = trim(preg_replace(
+                '/^\* /m',
+                '',
+                $xml->getNodeTextRelativeTo('p:notes', $release)
+            ));
+            if ($notes) {
+                $notes .= "\n";
+            }
             $changes[$version] = array(
                 'api' => $xml->getNodeTextRelativeTo(
                     'p:version/p:api', $release
@@ -176,11 +184,7 @@ public function migrateToChangelogYml($xml)
                     'identifier' => $license->textContent,
                     'uri' => $license->getAttribute('uri')
                 ),
-                'notes' => preg_replace(
-                    '/^\* /m',
-                    '',
-                    trim($xml->getNodeTextRelativeTo('p:notes', $release))
-                ) . "\n"
+                'notes' => $notes,
             );
         }
         $changes = array_reverse($changes);