Style, phpdoc.

horde · Oct 25, 2017 · 830eeb2 · 830eeb2
1 parent 6514ea9
commit 830eeb2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/lib/Components/Component/Source.php b/lib/Components/Component/Source.php
@@ -107,9 +107,8 @@ public function getChangelog($helper)
         $base = $this->getFactory()->getGitRoot()->getRoot();
         return $helper->getChangelog(
             preg_replace(
-                '#^' . $base . '#', '', realpath($this->_directory)
-            ),
-            $this->_directory
+                '#^' . $base . '#', '', $this->_directory
+            )
         );
     }
 

diff --git a/lib/Components/Helper/ChangeLog.php b/lib/Components/Helper/ChangeLog.php
@@ -67,14 +67,14 @@ public function __construct(
      * @param string                 $file    Path to the package.xml.
      * @param array                  $options Additional options.
      *
-     * @return NULL
+     * @return string  Path to the updated package.xml file.
      */
     public function packageXml($log, $xml, $file, $options)
     {
         if (file_exists($file)) {
             if (empty($options['pretend'])) {
                 $xml->addNote($log);
-                file_put_contents($file, (string) $xml);
+                file_put_contents($file, (string)$xml);
                 $this->_output->ok(
                     'Added new note to version ' . $xml->getVersion() . ' of ' . $file . '.'
                 );
@@ -203,8 +203,6 @@ public function changesFileExists()
      *
      * @param string $entry   Change log entry to add.
      * @param string $changes Path to the CHANGES file.
-     *
-     * @return NULL
      */
     public function addChange($entry, $changes)
     {

diff --git a/lib/Components/Module/Change.php b/lib/Components/Module/Change.php
@@ -142,8 +142,8 @@ public function handle(Components_Config $config)
     {
         $options = $config->getOptions();
         $arguments = $config->getArguments();
-        if (!empty($options['changed'])
-            || (isset($arguments[0]) && $arguments[0] == 'changed')) {
+        if (!empty($options['changed']) ||
+            (isset($arguments[0]) && $arguments[0] == 'changed')) {
             $this->_dependencies->getRunnerChange()->run();
             return true;
         }

diff --git a/lib/Components/Runner/Update.php b/lib/Components/Runner/Update.php
@@ -44,13 +44,14 @@ class Components_Runner_Update
     /**
      * Constructor.
      *
-     * @param Components_Config       $config  The configuration for the current job.
-     * @param Component_Output        $output  The output handler.
+     * @param Components_Config $config  The configuration for the current job.
+     * @param Component_Output $output   The output handler.
      */
     public function __construct(
         Components_Config $config,
         Components_Output $output
-    ) {
+    )
+    {
         $this->_config  = $config;
         $this->_output = $output;
     }