Build error message once.

horde · Feb 22, 2017 · de4d96f · de4d96f
1 parent 78bbe2d
commit de4d96f
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/Application.php b/lib/Application.php
@@ -344,6 +344,11 @@ public function configSpecialValues($what)
      */
     public function removeUserData($user)
     {
+        $err = sprintf(
+            _("There was an error removing an address book for %s"),
+            $user
+        );
+
         /* We need a clean copy of the $cfgSources array here.*/
         $cfgSources = Turba::availableSources();
         foreach ($cfgSources as $sourceId => $source) {
@@ -363,7 +368,7 @@ public function removeUserData($user)
                     continue;
                 } catch (Turba_Exception $e) {
                     Horde::log($e, 'ERR');
-                    throw new Turba_Exception(sprintf(_("There was an error removing an address book for %s"), $user));
+                    throw new Turba_Exception($err);
                 }
             }
         }
@@ -395,7 +400,7 @@ public function removeUserData($user)
                 continue;
             } catch (Turba_Exception $e) {
                 Horde::log($e, 'ERR');
-                throw new Turba_Exception(sprintf(_("There was an error removing an address book for %s"), $user));
+                throw new Turba_Exception($err);
             }
         }
 
@@ -408,7 +413,7 @@ public function removeUserData($user)
             }
         } catch (Horde_Share_Exception $e) {
             Horde::log($e, 'ERR');
-            throw new Turba_Exception(sprintf(_("There was an error removing an address book for %s"), $user));
+            throw new Turba_Exception($err);
         }
     }