Make lib/Page/*.Page.php compatible with PHP 8.2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function signature must be compatible to the Base Class. Fixes broken wicked for PHP8.2
Fix Function signature to be compatible with base class. Was broken with PHP8.2
Fix function signature to be compatible with base class, required for PHP 8.2
TDannhauer
changed the title
Make function signature compatible to base class
Make function signature compatible with base class
Make function signature compatible with base class for PHP8.2
Make function signature compatible with base class for PHP8.2
Make function signature compatible to base class for PHP8.2
|
added also changes for getPermissions() |
|
@yunosh Could you take a look at this PR? |
Closed
Fix Wicked to make pages editable again with PHP 8.2
|
Any news or reviews? |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP8.2 requires compatible interfaces between base class and extended classes. This PR unifies the interfaces