Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Hori,
I hope that you don't mind the changes but i found your package useful and i want to use it in my desktop software. However i found out that the customization options by default were not enough to make it usable for desktop so i extended you package with few more options.
The change list includes the following changes:
I have some other ideas on how we can improve the package, but i think this is a good start, in the following days i will open few more prs that i am working on but i do believe that we should spent some time to refactor the code and get rid of the functions inside the views as they are really redundant since we already initialize all configs when we call the constructor, i didn't do any refactoring as i think it's your decision but do let me know if you want to go there at some point till then i will try to keep the code style in your format.
let me know if you want me to make any changes in the comments bellow.
Best regards and i hope this gets merged,
Kristifor.