Fix linting errors

horia141 · Jul 8, 2018 · 0c21ce1 · 0c21ce1
1 parent 1650e5e
commit 0c21ce1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/config.ts b/src/config.ts
@@ -1,4 +1,4 @@
-import { Module, Global } from "@nestjs/common";
+import { Global, Module } from "@nestjs/common";
 import * as dotenv from "dotenv";
 import * as fs from "fs";
 
@@ -33,7 +33,11 @@ export class ConfigService {
 
     public get port(): number {
         // tslint:disable:no-string-literal
-        return parseInt(this.envConfig["PORT"], 10);
+        const port = parseInt(this.envConfig["PORT"], 10);
+        if (!Number.isSafeInteger(port)) {
+            throw new Error(`Invalid port value ${this.envConfig["PORT"]}`);
+        }
+        return port;
     }
 }
 

diff --git a/test/config-test.ts b/test/config-test.ts
@@ -32,7 +32,7 @@ PORT=10001
     it("can be constructed for testing", () => {
         const configService = ConfigService.forTesting();
 
-        expect(() => configService.env).to.throw;
-        expect(() => configService.port).to.throw;
+        expect(() => configService.env).to.throw();
+        expect(() => configService.port).to.throw();
     });
 });