Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address some diffs with lambda_proxy #196

Merged
merged 1 commit into from May 8, 2019
Merged

fix: address some diffs with lambda_proxy #196

merged 1 commit into from May 8, 2019

Conversation

theburningmonk
Copy link
Collaborator

  1. body is object not string;
  2. ordering of props;
  3. queryStringParameters return {} instead of null;
  4. pathParameters return {} instead of null;
  5. stageVariables return {} instead of null;
  6. no requestContext.domainName and requestContext.domainPrefix

cc/ @andrhamm

@theburningmonk
fix: address some diffs with lambda_proxy
c9669ab 
1) body is object not string; 2) ordering of props; 3)
queryStringParameters return {} instead of null; 4) pathParameters
return {} instead of null; 5) stageVariables return {} instead of null;
6) no requestContext.domainName and requestContext.domainPrefix
@theburningmonk
Copy link
Collaborator Author

still not addressed: multivalue query string params and headers, not sure how that's done in API Gateway at the moment, don't see the multi-value params in $input.params, pinged some AWS folks to see if they can answer

@theburningmonk theburningmonk merged commit a907ba4 into master May 8, 2019
@theburningmonk theburningmonk deleted the feature/lambda_proxy_template_update branch May 8, 2019 21:42
@theburningmonk
Copy link
Collaborator Author

🎉 This PR is included in version 1.19.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

ss-betseqnzr pushed a commit to BetSEQNZR/serverless-step-functions that referenced this pull request Sep 8, 2023
@theburningmonk
Merge pull request serverless-operations#196 from horike37/feature/la…
dbe7d4d 
…mbda_proxy_template_update

fix: address some diffs with lambda_proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@theburningmonk