full support for minItems & maxItems

[medfreeman]

closes #476

[horiuchi]

Thank you for your contribution! 👍
So awesome feature!

I think the strictArraySize option is unnecessary and should always be enabled. What do you think?

[medfreeman]

Thanks!

The thing is this feature can complicate consumer's code a bit, because in strict mode a tuple will be incompatible with an array.
As long as you're happy with this, i'm happy either way.
There's a case for not adding too much options too!

[medfreeman]

Tell me what you choose and i'll remove the option and the test infra change if necessary.
Thanks!

[horiuchi]

I don't want to add too many options either, so please remove the options.

The complexity of the type is not a problem for me.
I'd rather have the TypeScript compiler warn us more correctly by type definition.

[medfreeman]

it's ready!

[horiuchi]

@medfreeman Thank you for awesome work! 👍

[crizo23]

@medfreeman @horiuchi

The one negative I can see of the tuples is that for types defined as:
"ArrayOfFoos": { "type": "array", "items": { "$ref": "#/components/schemas/Foo" }, "minItems": 0, "maxItems": 500 }

results in:
export type ArrayOfFoos = [ Foo ?, Foo ?, Foo ?, Foo ?, ..all the way to 500 ];

resulting in a rather large type.
I understand that this provides a type that is restricted by min/max length. Was there any way to do this differently?

[horiuchi]

@crizo23 Thank you for your information. That's a problem.

One idea would be to simply revert to an unlimited number of types as before if maxItems exceeds some threshold, although it would be a loose definition of a type.
For example, if the threshold is set to 5, then up to maxItems of 5, the type will be generated as usual for [Foo, Foo, Foo, Foo, Foo] and maxItems, but when maxItems exceeds the threshold, the type will always be generated as [Foo, Foo, Foo, Foo, Foo, ... Foo].

[crizo23]

@crizo23 Thank you for your information. That's a problem.

One idea would be to simply revert to an unlimited number of types as before if maxItems exceeds some threshold, although it would be a loose definition of a type.
For example, if the threshold is set to 5, then up to maxItems of 5, the type will be generated as usual for [Foo, Foo, Foo, Foo, Foo] and maxItems, but when maxItems exceeds the threshold, the type will always be generated as [Foo, Foo, Foo, Foo, Foo, ... Foo].

@horiuchi I don't think a "threshold" is the answer, as that would be different for anyone using the library. I more meant, is there a better/fancier way to do this in Typescript". The answer is probably "no", in that case I think there's no way around having maxItems of tuples in the array type.