Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vendor media types (allow periods in application/*+json) #497

Merged
merged 2 commits into from
May 11, 2021
Merged

Support vendor media types (allow periods in application/*+json) #497

merged 2 commits into from
May 11, 2021

Conversation

glen-84
Copy link
Contributor

@glen-84 glen-84 commented May 5, 2021

Without this, the following media types are not accepted:

  • application/vnd.github+json
  • application/vnd.github.v3+json
  • application/vnd.github.v3.raw+json
  • application/vnd.github.v3.text+json
  • application/vnd.github.v3.html+json
  • application/vnd.github.v3.full+json

@glen-84
Copy link
Contributor Author

glen-84 commented May 5, 2021

Something is still causing response bodies to be empty. I have to go AFK for a while, but I'll look into this later tonight or tomorrow.

@horiuchi
Copy link
Owner

Thank you for your contribution! 👍

This change looks good to me.
However, if you change the functionality, please add the test pattern at the same pull request.

@glen-84
Copy link
Contributor Author

glen-84 commented May 10, 2021

@horiuchi,

I've added a test. I wasn't able to run the tests locally, as they don't appear to run correctly on Windows (possibly related to EOL characters). However, it seems to be passing.

Unrelated: Shouldn't this be node_modules (plural)?

@horiuchi
Copy link
Owner

Thank you for adding the unit test. It seems to have passed the test.
I do not have a Windows environment, so please let me know if there are any problems.

Thank you!

@horiuchi horiuchi merged commit 54bd501 into horiuchi:master May 11, 2021
@horiuchi
Copy link
Owner

Released by v3.11.0

@glen-84 glen-84 deleted the vendor-media-types branch May 11, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants