Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node version requirement #7

Merged
merged 1 commit into from Aug 13, 2014

Conversation

9point6
Copy link
Contributor

@9point6 9point6 commented Aug 8, 2014

Hi,

Why is the version requirement for this project >=0.4.0 <= 0.10.10?

Is there something that is broken in 0.10.11 and later?

Thanks.

@horixon
Copy link
Owner

horixon commented Jun 18, 2014

I haven't tested it on anything newer then 0.10.10. If it's working feel free to update and send me a pull request. Thanks.

@9point6
Copy link
Contributor Author

9point6 commented Jun 19, 2014

Ah okay, will let you know

@Tenzer
Copy link

Tenzer commented Jun 20, 2014

I have been running immortal-ntwitter on the most recent stable version of Nodd for the last two years, I believe, and I haven't had any issues with compatibility problems.

The requirement could probably be loosened to include the entire 0.10.* range. In case an incompatible version pops up in the range, it can be updated in the requirements.

@9point6
Copy link
Contributor Author

9point6 commented Jun 20, 2014

yeah, I can confirm it seems to be working fine on 0.10.28.

Should I remove the upper bound entirely in the PR? Since the modules that it depends on in node are probably unlikely to change now.

what do you think?

Also upped the version number since editing package.json anyway
@9point6
Copy link
Contributor Author

9point6 commented Aug 8, 2014

Changed package.json to reflect the discussion

horixon added a commit that referenced this pull request Aug 13, 2014
@horixon horixon merged commit 33e39ae into horixon:master Aug 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants