Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs the unstripped bin/horizon-eda executable #558

Open
yurivict opened this issue Jan 31, 2021 · 7 comments
Open

Installs the unstripped bin/horizon-eda executable #558

yurivict opened this issue Jan 31, 2021 · 7 comments

Comments

@yurivict
Copy link

Warning: 'bin/horizon-eda' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
@carrotIndustries
Copy link
Member

Every linux distro I'm aware of (at least debian and arch) take care of stripping binaries during packaging, so I consider this to be a non-issue.

@yurivict
Copy link
Author

No, they have to do this by hand or not care about stripping at all. This is why this warning is there.

@carrotIndustries
Copy link
Member

No, they have to do this by hand or not care about stripping at all

Arch Linux at least automatically strips binaries during packaging. Flatpak does so as well and extracts debug symbols while doing so.

In fact, make install installing non-stripped binaries is intended behaviour: https://www.gnu.org/prep/standards/html_node/Standard-Targets.html

Do not strip executables when installing them.

Feel free to open a PR that adds the install-strip target if FreeBSD (guessing from context, should have been mentioned) really needs it.

@yurivict
Copy link
Author

yurivict commented Jun 2, 2021

Arch Linux at least automatically strips binaries during packaging.

I don't think so. Arch just runs make install.

In fact, make install installing non-stripped binaries is intended behaviour: https://www.gnu.org/prep/standards/html_node/Standard-Targets.html

This document contains the paragraph:

‘install-strip’

    Like install, but strip the executable files while installing them. In simple cases, this target can use the install target in a simple way:

    install-strip:
            $(MAKE) INSTALL_PROGRAM='$(INSTALL_PROGRAM) -s' \
                    install

You don't have the install-strip target.

@RX14
Copy link

RX14 commented Jun 2, 2021

I don't think so. Arch just runs make install.

Arch linux's makepkg strips the binaries itself after make install runs and before the final package is compressed. This is what most linux distros do. I'm sure everyone would be happy to add an install-strip target, however it's not a bug that such a target doesn't exist, only a feature request.

@carrotIndustries
Copy link
Member

I'm really curious why FreeBSD needs such a target while any other package manager doesn't. How does FreeBSD handle the creation of debug symbol packages?

@yurivict
Copy link
Author

yurivict commented Jun 2, 2021

I'm really curious why FreeBSD needs such a target while any other package manager doesn't. How does FreeBSD handle the creation of debug symbol package

This is because packages can be built with and without debug info. This is triggered from the port, and most GNU make projects strip binaries themselves because they have the install-strip target. Blanket stripping isn't good because it would be double-stripping in many cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants