Remove unnecessary setter method for state

horizontalsystems · Mar 13, 2019 · 07febf1 · 07febf1
1 parent 3b53172
commit 07febf1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 14 deletions.
diff --git a/bitcoinkit/src/main/kotlin/io/horizontalsystems/bitcoinkit/blocks/BlockSyncer.kt b/bitcoinkit/src/main/kotlin/io/horizontalsystems/bitcoinkit/blocks/BlockSyncer.kt
@@ -118,7 +118,7 @@ class BlockSyncer(
             try {
                 transactionProcessor.process(merkleBlock.associatedTransactions, block, state.iterationHasPartialBlocks, realm)
             } catch (e: BloomFilterManager.BloomFilterExpired) {
-                state.setIteration(hasPartialBlocks = true)
+                state.iterationHasPartialBlocks = true
             }
 
             if (!state.iterationHasPartialBlocks) {
@@ -146,19 +146,12 @@ class BlockSyncer(
     private fun handlePartialBlocks() {
         addressManager.fillGap()
         bloomFilterManager.regenerateBloomFilter()
-        state.setIteration(hasPartialBlocks = false)
+        state.iterationHasPartialBlocks = false
     }
 
     private fun clearBlockHashes() {
         storage.deleteBlockchainBlockHashes()
     }
 
-    class State {
-        var iterationHasPartialBlocks = false
-            private set
-
-        fun setIteration(hasPartialBlocks: Boolean) {
-            iterationHasPartialBlocks = hasPartialBlocks
-        }
-    }
+    class State(var iterationHasPartialBlocks: Boolean = false)
 }
diff --git a/bitcoinkit/src/test/kotlin/io/horizontalsystems/bitcoinkit/blocks/BlockSyncerTest.kt b/bitcoinkit/src/test/kotlin/io/horizontalsystems/bitcoinkit/blocks/BlockSyncerTest.kt
@@ -181,7 +181,7 @@ class BlockSyncerTest : Spek({
         it("handles partial blocks") {
             verify(addressManager).fillGap()
             verify(bloomFilterManager).regenerateBloomFilter()
-            verify(state).setIteration(false)
+            verify(state).iterationHasPartialBlocks = false
         }
 
         it("clears partial blocks") {
@@ -209,7 +209,7 @@ class BlockSyncerTest : Spek({
 
                 verify(addressManager).fillGap()
                 verify(bloomFilterManager).regenerateBloomFilter()
-                verify(state).setIteration(false)
+                verify(state).iterationHasPartialBlocks = false
             }
         }
 
@@ -248,7 +248,7 @@ class BlockSyncerTest : Spek({
         it("handles partial blocks") {
             verify(addressManager).fillGap()
             verify(bloomFilterManager).regenerateBloomFilter()
-            verify(state).setIteration(false)
+            verify(state).iterationHasPartialBlocks = false
         }
 
         it("clears partial blocks") {
@@ -443,7 +443,7 @@ class BlockSyncerTest : Spek({
             it("sets state as it left partially handled blocks") {
                 blockSyncer.handleMerkleBlock(merkleBlock, maxBlockHeight)
 
-                verify(state).setIteration(hasPartialBlocks = true)
+                verify(state).iterationHasPartialBlocks = true
             }
         }