Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

when sending segwit transactions we're still using P2PKH (with BIP44) for change addresses. Should be P2WPKH. #407

Closed
esengulov opened this issue Jul 29, 2019 · 1 comment · Fixed by #410
Closed

when sending segwit transactions we're still using P2PKH (with BIP44) for change addresses. Should be P2WPKH. #407

esengulov opened this issue Jul 29, 2019 · 1 comment · Fixed by #410
Labels
enhancement Enhancement of existing feature

Comments

@esengulov
Copy link
Member

Get familiar with the thread here, bitcoin-dot-org/Bitcoin.org#3054 (comment)
@esengulov esengulov added the enhancement Enhancement of existing feature label Jul 29, 2019
@crwatkins
Copy link

Be sure to switch to BIP49 paths (or BIP84 paths as appropriate).

@esengulov esengulov mentioned this issue Aug 1, 2019
Closed
esen added a commit that referenced this issue Aug 2, 2019
@esen
Wrap peerStates removal in SyncedReadyPeerManager (#407)
8da43b2
esen added a commit that referenced this issue Aug 2, 2019
@esen
Ability to set change output script type (#407)
7d7c292
This was referenced Aug 2, 2019
Merged
Closed
Closed
ant013 added a commit that referenced this issue Aug 2, 2019
@ant013
Merge pull request #409 from horizontalsystems/bugfix
915501e 
Wrap peerStates removal in SyncedReadyPeerManager (#407)
ant013 added a commit that referenced this issue Aug 2, 2019
@ant013
Merge pull request #410 from horizontalsystems/segwit_change_address
852b822 
Ability to set change output script type (#407)
esen added a commit that referenced this issue Aug 2, 2019
@esen
Set default changeScriptType (#407)
7155d61
ant013 added a commit that referenced this issue Aug 2, 2019
@ant013
Merge pull request #413 from horizontalsystems/segwit_change_address
dc22694 
Set default changeScriptType (#407)
@esen esen mentioned this issue Aug 2, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ability to set change output script type (#407) horizontalsystems/bitcoin-kit-ios
2 participants
@esengulov @crwatkins