Core refactoring #22
Merged
Core refactoring #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add Room database - remove Realm - write EthereumKit with tests
- Move SyncState to BlockchainApi
- Fix transactions fetching from database - Fix demo app
omurovch
reviewed
Feb 22, 2019
|
|
||
| abstract fun balanceDao(): BalanceDao | ||
| abstract fun gasPriceDao(): GasPriceDao | ||
| abstract fun lastBlockHeight(): LastBlockHeightDao |
There was a problem hiding this comment.
let's rename to lastBlockHeightDao()
omurovch
reviewed
Feb 22, 2019
| private fun buildDatabase(context: Context, databaseName: String): KitDatabase { | ||
| return Room.databaseBuilder(context, KitDatabase::class.java, databaseName) | ||
| .fallbackToDestructiveMigration() | ||
| .allowMainThreadQueries() |
There was a problem hiding this comment.
why do we need to allow queries in main thread?
omurovch
approved these changes
Feb 22, 2019
abdrasulov
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #21