Fix rounding errors on log2 of large numbers #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Replaces
math.floor(math.log(x, 2))with a custom version which does not suffer from rounding errors on large numbers.bct()is still recursive, this has the effect that the data string will be limited to ~1000 bits due to Python's recursion limit.The bit string could be built by stepping through the string length (
s()) and appending each symbol to avoid the recursion if needed.The program string is not converted in normal operation, so that can get as large as it needs to and will be treated correctly, arithmetically.