HORNETQ-1417 OpenWire support -- Producer Flow Control #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
close for now. |
|
We are not closing PRs any longer.. that causes a lot of confusion on github |
|
github has been creating issues with closing a PR and rebasing it... just let us know when you're ready.. nobody should merge your PR We are closing a PR now only when it's meant for good |
|
@celbert actually the join breaks the tests. It shouldn't join() at the end of it. It is supposed to go on doing other stuff while the thread is dying. I'll find a proper place to join it. |
|
teardown? |
|
I'll give it a try. |
gaohoward
force-pushed
the
master_HORNETQ-1417
branch
from
e4f05aa
to
fae1681
Compare
Implement OpenWire producer flow control. Based on configuration, when a queue's memory space is full, the producer can either be blocked (via client side window size or server side blocking), or get a relevant failure exception. The details are given in this link: http://activemq.apache.org/producer-flow-control.html
gaohoward
force-pushed
the
master_HORNETQ-1417
branch
from
fae1681
to
c1da35e
Compare
|
yes it works. I've done a forced push just now. |
clebertsuconic
added a commit
that referenced
this pull request
Sep 29, 2014
HORNETQ-1417 OpenWire support -- Producer Flow Control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement OpenWire producer flow control. Based on configuration, when
a queue's memory space is full, the producer can either be blocked (via
client side window size or server side blocking), or get a relevant
failure exception. The details are given in this link:
http://activemq.apache.org/producer-flow-control.html