Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary release still not compiled for 10.11+ #191

Open
tessus opened this issue Jul 31, 2017 · 13 comments
Open

binary release still not compiled for 10.11+ #191

tessus opened this issue Jul 31, 2017 · 13 comments

Comments

@tessus
Copy link
Contributor

tessus commented Jul 31, 2017

I've just noticed that the binary release is still only available for 10.12, which makes really no sense.
You only have to make the changes I've mentioned in #171 (comment)

In any case, I've created a binary for 10.11+ for anyone who needs it:
https://evermeet.cx/pub/macosx/Horos/Horos-2.2.0.zip

@boskar
Copy link

boskar commented Feb 14, 2018

Hello, do You think it is possible to backport current horos (3.0 beta) to 10.11?

@tessus
Copy link
Contributor Author

tessus commented Feb 15, 2018

I don't think there's a need to backport any code. You only have to make the changes in the project I described in #171 (comment)

@fvpolpeta
Copy link
Collaborator

fvpolpeta commented Feb 15, 2018 via email

@tessus
Copy link
Contributor Author

tessus commented Feb 15, 2018

@boskar when I pulled the latest code, I saw that the deployment target was actually set to 10.11.

Thus, the version which is available for download should run on 10.11, unless the release team compiled a version which is not the same as the code on github.

However, I also compiled a version (not tested though) and put it here:
https://evermeet.cx/pub/macosx/Horos/Horos-3.0.0.rc1.zip

@fvpolpeta after the reorganization of the source tree and project, there are 2 compile errors, because paths are not set correctly by the scripts and Xcode. cmake and pkg-config cannot be found. Xcode does not use the user's environment PATH. cmake and pkg-config are not part of macOS, thus they are either in /opt/local/bin (macports) or some other directory for homebrew. In any case, I had to create a symbolic link in /bin for those 2 binaries.
Maybe you should use the README.md file to describe how to compile the project. Especially since the project does not compile out of the box. (also a lot of people don't know how to use git submodules)

@fvpolpeta
Copy link
Collaborator

fvpolpeta commented Feb 15, 2018 via email

@tessus
Copy link
Contributor Author

tessus commented Feb 15, 2018

@fvpolpeta

README.md with build instructions and make a pull request, we will be very pleased to accept it and incrementally improve it.

Yep, sounds good. Will do. Not sure when I will be able to get around to it though, maybe this weekend.

Regarding the 10.11 version, we will be investigating that as mentioned. Perhaps, it’s something related to the signing process/archiving of XCode. We will see.

I'm not sure what you mean by that. You've changed the deployment target already, so there's nothing else you have to do. If you compile the current master, it will run on 10.11 and later.

@horosproject
Copy link
Owner

horosproject commented Feb 15, 2018 via email

@tessus
Copy link
Contributor Author

tessus commented Feb 15, 2018

When I opened this issue, the minimum deployment target in the project was 10.12.

Now it is not. So you must have changed it from 10.12 to 10.11. ;-)

@fvpolpeta
Copy link
Collaborator

fvpolpeta commented Feb 15, 2018 via email

@tessus
Copy link
Contributor Author

tessus commented Feb 15, 2018

Ah, I didn't know that people still had an issue with 10.11. It compiles perfectly (there are a few deprecation warnings for NSForm), but other than that this project has no warnings - which is remarkable btw.

I've already upgraded to High Sierra, but I still have a backup of my 10.11 on an external disk, which I can boot up at any time.
(I compile other stuff for 10.9 and above, so that's not really an issue.)

You can always add me to a ticket by mentioning me. e.g.: /cc @tessus
In this case I can follow the 10.11 issues...

@fvpolpeta
Copy link
Collaborator

fvpolpeta commented Feb 15, 2018 via email

@tessus
Copy link
Contributor Author

tessus commented Feb 16, 2018

Hmm, this makes no sense. If you build for 10.11 it has to run on 10.11, otehrwise there's a bug in Xcode. Signing should be OS version agnostic. Very strange, I hope you can figure out what the problem is.

@tessus
Copy link
Contributor Author

tessus commented Feb 19, 2018

@fvpolpeta

README.md with build instructions and make a pull request, we will be very pleased to accept it and incrementally improve it.

please see #273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants