Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Restrict numpy<1.24.0 for pandas<1.1.0, h5py<3.0, mxnet #3805

Merged
merged 3 commits into from Jan 5, 2023

Conversation

maxhgerlach
Copy link
Collaborator

@maxhgerlach maxhgerlach commented Jan 4, 2023

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes #3804

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
@maxhgerlach maxhgerlach changed the title Docker: Restrict numpy<1.24.0 for pandas<1.1.0 Docker: Restrict numpy<1.24.0 for pandas<1.1.0, h5py<3.0 Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Unit Test Results

  1 155 files  +  1 038    1 155 suites  +1 038   13h 27m 42s ⏱️ + 11h 29m 49s
     841 tests +         3       788 ✔️ +     158       53 💤  -    155  0 ±0 
23 809 runs  +21 349  17 023 ✔️ +15 329  6 786 💤 +6 020  0 ±0 

Results for commit 320e293. ± Comparison against base commit f99dfbf.

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Unit Test Results (with flaky tests)

  1 370 files  +  1 253    1 370 suites  +1 253   14h 42m 12s ⏱️ + 12h 44m 19s
     841 tests +         3       784 ✔️ +     154       53 💤  -    155  3 +3  1 🔥 +1 
28 317 runs  +25 857  19 817 ✔️ +18 123  8 496 💤 +7 730  3 +3  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 320e293. ± Comparison against base commit f99dfbf.

Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
@maxhgerlach maxhgerlach changed the title Docker: Restrict numpy<1.24.0 for pandas<1.1.0, h5py<3.0 Docker: Restrict numpy<1.24.0 for pandas<1.1.0, h5py<3.0, mxnet Jan 5, 2023
@maxhgerlach maxhgerlach changed the title Docker: Restrict numpy<1.24.0 for pandas<1.1.0, h5py<3.0, mxnet Restrict numpy<1.24.0 for pandas<1.1.0, h5py<3.0, mxnet Jan 5, 2023
@maxhgerlach maxhgerlach changed the title Restrict numpy<1.24.0 for pandas<1.1.0, h5py<3.0, mxnet Docker: Restrict numpy<1.24.0 for pandas<1.1.0, h5py<3.0, mxnet Jan 5, 2023
@maxhgerlach maxhgerlach marked this pull request as ready for review January 5, 2023 12:23
@maxhgerlach
Copy link
Collaborator Author

This fixes building all test images.

Going forward it will be good to find a nicer solution (i.e., update dependencies) so we will be able to test with Numpy 0.24+ in the future.

In the latest run of Build and Test heads (test-cpu-openmpi-gloo-py3_8-tfhead-keras_none-torchhead-mxnethead-pyspark3_3_1) there was a failure 3x with test_ray_elastic.py::test_fault_tolerance_hosts_added_and_removed, but I suppose that's flakiness. The previous CI pipeline run for this PR was fine there.

@maxhgerlach maxhgerlach merged commit 4ad1d43 into master Jan 5, 2023
@maxhgerlach maxhgerlach deleted the restrict-numpy-version-for-old-pandas branch January 6, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CI: Builds fail with Numpy 1.24
3 participants