Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider CONTAINER_ID in host_hash #1525

Merged
merged 4 commits into from
Nov 20, 2019

Conversation

EnricoMi
Copy link
Collaborator

YARN containers do not share memory, so each YARN container must be considered its own 'host'.

Adds lots of documentation around how Horovod orchestrates Spark and MPI.

Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @EnricoMi! Could you just rebase your branch from master? There is a fix for the integration test failures that was landed a few days ago. Once tests pass, let's land this.

@EnricoMi
Copy link
Collaborator Author

@tgaddair: done, all tests pass. Thanks!

Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@tgaddair tgaddair merged commit c7dfdce into horovod:master Nov 20, 2019
@EnricoMi EnricoMi deleted the branch-yarn-containers branch November 25, 2019 17:22
jeffdaily pushed a commit to ROCm/horovod that referenced this pull request Nov 27, 2019
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
DelphianCalamity pushed a commit to DelphianCalamity/horovod that referenced this pull request Apr 18, 2020
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants