Add extra build flag 'HOROVOD_BUILD_ARCH_FLAGS' #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romerojosh
reviewed
Feb 28, 2020
setup.py
Outdated
| @@ -118,7 +118,8 @@ def get_supported_instruction_set_flags(flags_to_check): | |||
| def get_cpp_flags(build_ext): | |||
| last_err = None | |||
| default_flags = ['-std=c++11', '-fPIC', '-O2', '-Wall', '-fassociative-math', '-ffast-math', '-ftree-vectorize', '-funsafe-math-optimizations'] | |||
| avx_fma_flags = get_supported_instruction_set_flags(['-mf16c', '-mavx', '-mfma']) | |||
| avx_env_vars = os.environ.get('HOROVOD_BUILD_ARCH_FLAGS') | |||
| avx_fma_flags = get_supported_instruction_set_flags(['-mf16c', '-mavx', '-mfma']) if avx_env_vars is None else avx_env_vars.split() | |||
There was a problem hiding this comment.
Looks good to me but I wonder if we should rename these variables to something more generic, like avx_env_vars -> build_arch_flags_env and avx_fma_flags -> build_arch_flags?
There was a problem hiding this comment.
+1, looks great, I think making the variable names consistent with the environment variable is a good idea.
Add env variable to specify architecture-specific compiler flags. For example, to be compatible with the older CPU architecture 'Sandy Bridge' and tune for 'Broadwell': HOROVOD_BUILD_ARCH_FLAGS="-march=sandybridge -mtune=broadwell" ... pip install horovod Signed-off-by: Nicolas V Castet <nvcastet@us.ibm.com>
Signed-off-by: Nicolas V Castet <nvcastet@us.ibm.com>
tgaddair
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add env variable to specify architecture-specific compiler flags.
For example, to be compatible with the older CPU architecture 'Sandy Bridge' and tune for 'Broadwell':
HOROVOD_BUILD_ARCH_FLAGS="-march=sandybridge -mtune=broadwell" ... pip install horovod
Signed-off-by: Nicolas V Castet nvcastet@us.ibm.com