Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable setting Horovod background thread affinity in general. #1881

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Enable setting Horovod background thread affinity in general. #1881

merged 1 commit into from
Apr 23, 2020

Conversation

romerojosh
Copy link
Collaborator

This PR converts the ability to set the Horovod background thread affinity from a CCL backend specific option to one that is generally available. This is controllable via the new environment variable HOROVOD_THREAD_AFFINITY. The behavior of the existing HOROVOD_CCL_BGT_AFFINITY environment variable is retained.

@romerojosh
Enable setting Horovod background thread affinity in general.
39ff8e9 
Signed-off-by: Josh Romero <joshr@nvidia.com>
tgaddair
tgaddair approved these changes Apr 23, 2020
View reviewed changes
Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Perhaps in a follow-up PR, I think it would be useful to document usage of env variables like this for users who may be able to benefit from them.

@tgaddair tgaddair merged commit 8b3aecd into horovod:master Apr 23, 2020
@tgaddair tgaddair mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romerojosh @tgaddair