Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove torchvision from pytorch extra #1899

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Remove torchvision from pytorch extra #1899

merged 1 commit into from
Apr 23, 2020

Conversation

tgaddair
Copy link
Collaborator

Fixes #1898.

Signed-off-by: Travis Addair taddair@uber.com

@tgaddair
Remove torchvision from pytorch extra
1327b3b 
Signed-off-by: Travis Addair <taddair@uber.com>
@tgaddair tgaddair requested a review from EnricoMi April 23, 2020 17:46
@EnricoMi
Copy link
Collaborator

Should we add torchvision somewhere in the documentation, somewhere those examples are mentioned? It is mentioned in the contributors guide but people looking for examples might not look there.

EnricoMi
EnricoMi approved these changes Apr 23, 2020
View reviewed changes
Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comment, approved anyway

@tgaddair
Copy link
Collaborator Author

Should we add torchvision somewhere in the documentation, somewhere those examples are mentioned? It is mentioned in the contributors guide but people looking for examples might not look there.

Good point. I think we could add a README / requirements.txt file for the examples, so users know what dependencies they need to run them successfully. We could also use this as an opportunity to provide better instructions for running ResNet50 training, etc.

See: #1901.

@tgaddair tgaddair merged commit ec046bf into master Apr 23, 2020
@tgaddair tgaddair deleted the no-torchvision branch April 23, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnricoMi EnricoMi EnricoMi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard Torchvision Dependency
2 participants
@tgaddair @EnricoMi