Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass verbose from Estimator to SparkBackend #1922

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

carsonwang
Copy link
Contributor

@carsonwang carsonwang commented Apr 29, 2020

When I run the following code, currently I can not see the verbose=2 log from horovod.spark.runner like the generated mpirun command. We can create SparkBackend by using this verbose value to see the logs.

keras_estimator = hvd.KerasEstimator(num_proc=args.num_proc,
                                     store=store,
                                     model=model,
                                     optimizer=opt,
                                     loss='mae',
                                     metrics=[exp_rmspe],
                                     custom_objects=CUSTOM_OBJECTS,
                                     feature_cols=all_cols,
                                     label_cols=['Sales'],
                                     validation='Validation',
                                     batch_size=args.batch_size,
                                     epochs=args.epochs,
                                     verbose=2)

@tgaddair
Copy link
Collaborator

Hey @carsonwang, thanks for the fix! Could you sign the DCO and rebase your PR off master (to fix unit tests)?

Signed-off-by: Carson Wang <carson.wang@intel.com>
Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@tgaddair tgaddair merged commit 2b46e98 into horovod:master Apr 29, 2020
@carsonwang
Copy link
Contributor Author

Thanks @tgaddair !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants