Added optional initial_lr parameter to LearningRateScheduleCallback and updated docs #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd updated docs Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
alsrgv
reviewed
May 4, 2020
examples/keras_imagenet_resnet50.py
Outdated
| @@ -147,10 +147,11 @@ | |||
| hvd.callbacks.LearningRateWarmupCallback(warmup_epochs=args.warmup_epochs, verbose=verbose), | |||
There was a problem hiding this comment.
Pass initial_lr to LearningRateWarmupCallback as well?
There was a problem hiding this comment.
Good catch! Fixed.
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
nvcastet
reviewed
May 4, 2020
| @@ -99,9 +99,14 @@ def __init__(self, multiplier, start_epoch=0, end_epoch=None, staircase=True, | |||
| steps_per_epoch: The callback will attempt to autodetect number of batches per | |||
| epoch with Keras >= 2.0.0. Provide this value if you have an older | |||
| version of Keras. | |||
| initial_lr: Initial learning rate at the start of training. | |||
There was a problem hiding this comment.
In the doc above for this callback, could we explicitly mention that when using a constant multiplier, it applies to the initial_lr and not the current learning rate? (because different behavior than TF Keras 2.2 callback which takes current lr)
There was a problem hiding this comment.
Nevermind, I missed the description for class at
nvcastet
approved these changes
May 4, 2020
| @@ -99,9 +99,14 @@ def __init__(self, multiplier, start_epoch=0, end_epoch=None, staircase=True, | |||
| steps_per_epoch: The callback will attempt to autodetect number of batches per | |||
| epoch with Keras >= 2.0.0. Provide this value if you have an older | |||
| version of Keras. | |||
| initial_lr: Initial learning rate at the start of training. | |||
There was a problem hiding this comment.
Nevermind, I missed the description for class at
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1921.
Adds deprecation warnings with removed versions.
Fixes docs for SyncBatchNorm.
Signed-off-by: Travis Addair taddair@uber.com