Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed horovod.run to horovod.runner to simplify using interactive run mode #2099

Merged
merged 6 commits into from Jul 14, 2020

Conversation

tgaddair
Copy link
Collaborator

@tgaddair tgaddair commented Jul 13, 2020

The purpose of this PR is to simplify the process of using interactive run mode and to better clarify the package structure of Horovod.

Instead of doing this:

from horovod.run.runner import run

run(...)

Users can now do this:

import horovod

horovod.run(...)

As a result, the following have been renamed:

horovod.run -> horovod.runner
horovod.run.runner.py -> horovod.runner.launch.py

Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
@tgaddair tgaddair requested review from alsrgv and EnricoMi July 13, 2020 17:56
Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, aligns with horovod.spark.run

Copy link
Member

@alsrgv alsrgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
@tgaddair tgaddair merged commit 50d1e04 into master Jul 14, 2020
@tgaddair tgaddair deleted the run-pkg-rename branch July 14, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants