Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing run in tf keras elastic mode #2272

Merged
merged 2 commits into from Sep 15, 2020
Merged

Conversation

BobLiu20
Copy link
Contributor

Checklist before submitting

  • [ yes ] Did you read the contributor guide?
  • [ N/A ] Did you update the docs?
  • [ N/A ] Did you write any tests to validate this change?
  • [ N/A ] Did you update the CHANGELOG, if this change affects users?

Description

Can not run examples/elastic/tensorflow_keras_mnist_elastic.py in elastic mode.

Fixes # (issue).

  1. missing run decorator in elastic.py file. Just import it and working well now.

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @BobLiu20! Can you add this change to horovod/tensorflow/keras/elastic.py as well?

Signed-off-by: BobLiu20 <baifang20@qq.com>
@BobLiu20
Copy link
Contributor Author

Thanks for the PR, @BobLiu20! Can you add this change to horovod/tensorflow/keras/elastic.py as well?

Hi @tgaddair . Added it. Thanks.

Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, seems test failures are unrelated, so I'll take a look at those in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants