Update tf.keras hvd.allreduce() API to match tensorflow allreduce() #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron276h
force-pushed
the
update-tfkeras-allreduce
branch
from
2a3b61b
to
dc5f776
Compare
This comment has been minimized.
This comment has been minimized.
aaron276h
force-pushed
the
update-tfkeras-allreduce
branch
from
dc5f776
to
b4d5837
Compare
This comment has been minimized.
This comment has been minimized.
aaron276h
force-pushed
the
update-tfkeras-allreduce
branch
from
b4d5837
to
5a47a44
Compare
This comment has been minimized.
This comment has been minimized.
|
Test failures seems unrelated to the contents of this PR. |
|
Thanks @aaron276h, once #2439 lands I'll let you know so you can rebase. |
|
@aaron276h, the unit test fix has landed, please rebase when you get a chance. |
Signed-off-by: aaron276h <aaron@determined.ai>
Signed-off-by: aaron276h <aaron@determined.ai>
aaron276h
force-pushed
the
update-tfkeras-allreduce
branch
from
5a47a44
to
35e1cc4
Compare
|
Thanks for the quick fix @tgaddair! |
This comment has been minimized.
This comment has been minimized.
|
@tgaddair is it possible to re-run just the travis-ci build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tf.kerasallreaduce uses thetensorflowallreduce under the hood but does not currently match its API. This PR brings thetf.kerasallreduce API (mostly) in line with the tensorflow API.