Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Estimator: add petastorm reader_pool_type into constructor #2903

Merged
merged 1 commit into from May 7, 2021
Merged

Estimator: add petastorm reader_pool_type into constructor #2903

merged 1 commit into from May 7, 2021

Conversation

chongxiaoc
Copy link
Collaborator

@chongxiaoc chongxiaoc commented May 7, 2021 •
edited

Allow users to specify process_pool (default) or thread_pool for
petastorm reader.

Signed-off-by: Chongxiao Cao chongxiaoc@uber.com

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes # (issue).

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

@chongxiaoc chongxiaoc requested review from tgaddair and irasit May 7, 2021 21:17
@chongxiaoc
Estimator: add petastorm reader_pool_type into constructor
f88990d 
Allow users to specify process_pool (default) or thread_pool for
petastorm reader.

Signed-off-by: Chongxiao Cao <chongxiaoc@uber.com>
irasit
irasit approved these changes May 7, 2021
View reviewed changes
Copy link
Collaborator

@irasit irasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks.

@github-actions

This comment has been minimized.

Sign in to view
@chongxiaoc chongxiaoc merged commit c27159f into horovod:master May 7, 2021
@github-actions
Copy link

github-actions bot commented May 8, 2021

Unit Test Results

     763 files  ±0       763 suites  ±0   5h 33m 16s ⏱️ ±0s
     592 tests ±0       560 ✔️ ±0       32 💤 ±0  0 ❌ ±0 
15 758 runs  ±0  11 971 ✔️ ±0  3 787 💤 ±0  0 ❌ ±0 

Results for commit c27159f. ± Comparison against base commit c27159f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

@irasit irasit irasit approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chongxiaoc @tgaddair @irasit