TorchEstimator: use validation_steps instead of validation_steps_per_… #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epoch validation_steps_per_epoch could be None if user doesn't specify. Also modify unit test to cover val dataloader cases. Signed-off-by: Chongxiao Cao <chongxiaoc@uber.com>
…ataloader cases Signed-off-by: Chongxiao Cao <chongxiaoc@uber.com>
irasit
approved these changes
May 19, 2021
Unit Test Results 559 files ±0 559 suites ±0 5h 18m 37s ⏱️ ±0s For more details on these failures, see this check. Results for commit 255c2b9. ± Comparison against base commit 255c2b9. ♻️ This comment has been updated with latest results. |
tgaddair
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…epoch
validation_steps_per_epoch could be None if user doesn't specify.
Also modify unit test to cover val dataloader cases.
Signed-off-by: Chongxiao Cao chongxiaoc@uber.com
Checklist before submitting
Description
Fixes # (issue).
Review process to land