Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ray] disable capturing child tasks in placement group. #2920

Merged
merged 1 commit into from May 20, 2021

Conversation

richardliaw
Copy link
Collaborator

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

This fixes an existing bug with using a Ray-based shuffling dataloader, which we are developing separately.

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw
Copy link
Collaborator Author

cc @rkooo567 FYI

@rkooo567
Copy link

@richardliaw you said it didn't work right?

@github-actions
Copy link

github-actions bot commented May 20, 2021

Unit Test Results

     763 files  ±0       763 suites  ±0   5h 55m 48s ⏱️ ±0s
     597 tests ±0       560 ✔️ ±0       37 💤 ±0  0 ❌ ±0 
15 848 runs  ±0  11 959 ✔️ ±0  3 889 💤 ±0  0 ❌ ±0 

Results for commit 5b2f1f0. ± Comparison against base commit 5b2f1f0.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@chongxiaoc chongxiaoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgaddair tgaddair merged commit 5b2f1f0 into horovod:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants