lightning: turn off shuffling for validation dataset #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chongxiaoc
force-pushed
the
lightning_val_no_shuffle
branch
from
053665c
to
6e40e43
Compare
irasit
reviewed
Jun 11, 2021
horovod/spark/lightning/remote.py
Outdated
| @@ -222,7 +222,8 @@ def on_sanity_check_end(self, trainer, model): | |||
| def _set_data_loader_fn(transformation, schema_fields, batch_size, calculate_shuffle_buffer_size, data_loader_cls, num_epochs, store, verbose=False): | |||
|
|
|||
| @contextlib.contextmanager | |||
| def set_data_loader(model, data_path, dataloader_attr, reader_worker_count, reader_pool_type, should_read=True, name="", limit_step_per_epoch=-1): | |||
| def set_data_loader(model, data_path, dataloader_attr, reader_worker_count, reader_pool_type, | |||
| should_read=True, name="", limit_step_per_epoch=-1, is_val=False): | |||
There was a problem hiding this comment.
You can just move the shuffling_queue_capacity here instead of is_val.
There was a problem hiding this comment.
yep, sounds good
Signed-off-by: Chongxiao Cao <chongxiaoc@uber.com>
chongxiaoc
force-pushed
the
lightning_val_no_shuffle
branch
from
6e40e43
to
d07c694
Compare
irasit
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before submitting
Description
Fixes # (issue).
Review process to land