Use process_set size instead of world size in MXNet DistributedOptimizer/Trainer in quick return conditions. #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zer/Trainer in quick return conditions. Signed-off-by: Josh Romero <joshr@nvidia.com>
maxhgerlach
approved these changes
Aug 7, 2021
Unit Test Results (with flaky tests) 769 files ±0 769 suites ±0 6h 40m 38s ⏱️ ±0s For more details on these failures, see this check. Results for commit 3892d8a. ± Comparison against base commit 3892d8a. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small update to #3083 to add more usage of
process_set.size()in place of the world size.