Fix pytorch async dataloader race condition #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since petastorm reader can have infinite loops, main thread has to drain the queue in order to join the asynchronous worker thread. Otherwise queue could always be full and asynchronous worker stucks in queue.put(None). Also call close_async_loader() in lightning datamodule to close async dataloaders explicitly, to avoid uncaught exceptions. Signed-off-by: Chongxiao Cao <chongxiaoc@uber.com>
irasit
approved these changes
Aug 19, 2021
Unit Test Results (with flaky tests) 825 files ±0 825 suites ±0 6h 18m 54s ⏱️ ±0s For more details on these failures, see this check. Results for commit 24cdb21. ± Comparison against base commit 24cdb21. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since petastorm reader can have infinite loops, main thread has to drain
the queue in order to join the asynchronous worker thread. Otherwise
queue could always be full and asynchronous worker stucks in
queue.put(None).
Also call close_async_loader() in lightning datamodule to close async
dataloaders explicitly, to avoid uncaught exceptions.
Signed-off-by: Chongxiao Cao chongxiaoc@uber.com
Checklist before submitting
Description
Fixes #3119 .
Review process to land