Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove h5py<3 constraint as not needed for TF>2.5.0 #3301

Merged
merged 6 commits into from Dec 16, 2021
Merged

Remove h5py<3 constraint as not needed for TF>2.5.0 #3301

merged 6 commits into from Dec 16, 2021

Conversation

EnricoMi
Copy link
Collaborator

@EnricoMi EnricoMi commented Dec 7, 2021 •
edited

The h5py<3 constraint was needed for Spark and tensorfow<=2.5.0. Since we do not support that early tensorflow versions we can safely remove that constraint.

Fixes #3275.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited

Unit Test Results

     758 files  +   448       758 suites  +448   8h 27m 34s ⏱️ + 3h 15m 6s
     717 tests ±       0       668 ✔️ +     92       49 💤  -      92  0 ❌ ±0 
16 358 runs  +9 574  11 515 ✔️ +6 958  4 843 💤 +2 616  0 ❌ ±0 

Results for commit 7503b51. ± Comparison against base commit 5b8bc67.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited

Unit Test Results (with flaky tests)

     890 files  +     568       890 suites  +568   9h 38m 12s ⏱️ + 3h 33m 59s
     717 tests ±         0       664 ✔️ +     89       49 💤  -      92  4 ❌ +3 
19 178 runs  +12 052  13 472 ✔️ +8 639  5 699 💤 +3 409  7 ❌ +4 

For more details on these failures, see this check.

Results for commit 7503b51. ± Comparison against base commit 5b8bc67.

♻️ This comment has been updated with latest results.

@EnricoMi EnricoMi changed the title Remove h5py<3 constraint as not needed for TF>=2.5.0 Remove h5py<3 constraint as not needed for TF>2.5.0 Dec 8, 2021
@EnricoMi EnricoMi force-pushed the branch-remove-h5py-constraint branch 2 times, most recently from d6696c7 to 5158adb Compare December 8, 2021 20:35
@EnricoMi EnricoMi marked this pull request as ready for review December 9, 2021 09:40
@EnricoMi
Copy link
Collaborator Author

EnricoMi commented Dec 9, 2021

@tgaddair all green, good to go

@EnricoMi EnricoMi force-pushed the branch-remove-h5py-constraint branch from 5158adb to 4dcb0bf Compare December 12, 2021 15:36
@EnricoMi
Copy link
Collaborator Author

@maxhgerlach thanks, I have rebased again to see if recent macOS changes have a problem with this

@EnricoMi EnricoMi mentioned this pull request Dec 13, 2021
Merged
@EnricoMi EnricoMi force-pushed the branch-remove-h5py-constraint branch from 4dcb0bf to 6b4beca Compare December 13, 2021 12:04
@EnricoMi EnricoMi mentioned this pull request Dec 13, 2021
Merged
4 tasks
@EnricoMi
Copy link
Collaborator Author

Waiting for #3313 to land in master, rebasing and removing 6b4beca then.

@EnricoMi EnricoMi force-pushed the branch-remove-h5py-constraint branch from 6b4beca to b30b79b Compare December 15, 2021 10:08
@EnricoMi
Remove h5py<3 constraint as not needed for TF>=2.5.0
a7aa8ee 
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
@EnricoMi
Looks like we still need h5py for tensorflow 2.5.x
ffb0b12 
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
@EnricoMi
Install h5py<3 for tf<=2.5.x macos tests
cd4510b 
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
@EnricoMi
Fix macOS build step
64ea97d 
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
@EnricoMi
Building macOS images uses package version only
d36aa35 
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
@EnricoMi
Install h5py after tensorflow
7503b51 
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
@EnricoMi EnricoMi force-pushed the branch-remove-h5py-constraint branch from b30b79b to 7503b51 Compare December 15, 2021 18:43
@EnricoMi EnricoMi merged commit 8d34c85 into master Dec 16, 2021
@EnricoMi EnricoMi deleted the branch-remove-h5py-constraint branch December 16, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

@maxhgerlach maxhgerlach maxhgerlach approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot install horovod[spark] for Tensorflow 2.6
3 participants
@EnricoMi @tgaddair @maxhgerlach