Rework network interfaces args in horovod.run and horovodrun #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results (with flaky tests) 911 files + 90 911 suites +90 10h 3m 28s ⏱️ + 1h 9m 37s For more details on these failures, see this check. Results for commit b56af7d. ± Comparison against base commit 98db066. ♻️ This comment has been updated with latest results. |
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
EnricoMi
force-pushed
the
branch-nics-args
branch
from
6f383c0
to
586929e
Compare
maxhgerlach
approved these changes
Apr 20, 2022
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks network interfaces arguments in two places: the
horovod.runAPI and thehorovodrunCLI:The
horovod.runAPI deprecatesnetwork_interfaceargument in favour ofnetwork_interfaces, which becomes a list of strings, rather than a comma separated string that is to be split.The
horovodrunCLI replaces--network-interfacewith semantically more accurate--network-interfaces, which still takes a comma separated string of network interfaces, but also provides the new--network-interfaceargument, that semantically correctly expects a single network interface. That argument can be used multiple times to set multiple NICs.Arguably,
--network-interfacescould be removed completely, as--network-interfaceallows to specify multiple NICs. Unless, there is any use of comma separated strings.