Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark/Lightning: add missing tranform_spec for Petastorm datamodule #3543

Merged
merged 1 commit into from May 10, 2022

Conversation

chongxiaoc
Copy link
Collaborator

@chongxiaoc chongxiaoc commented May 10, 2022

Signed-off-by: Chongxiao Cao chongxiaoc@uber.com

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes #3540 .

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

@chongxiaoc chongxiaoc requested a review from Tixxx May 10, 2022 06:41
Fix issue#3540

Signed-off-by: Chongxiao Cao <chongxiaoc@uber.com>
@github-actions
Copy link

Unit Test Results

     821 files  ±0       821 suites  ±0   9h 25m 0s ⏱️ + 9m 0s
     768 tests ±0       725 ✔️ ±0       43 💤 ±0  0 ±0 
18 950 runs  ±0  13 655 ✔️ ±0  5 295 💤 ±0  0 ±0 

Results for commit d899497. ± Comparison against base commit 464c82e.

@github-actions
Copy link

Unit Test Results (with flaky tests)

     905 files  ±0       905 suites  ±0   9h 45m 56s ⏱️ + 9m 25s
     768 tests ±0       725 ✔️ ±0       43 💤 ±0  0 ±0 
21 164 runs  ±0  14 999 ✔️ ±0  6 165 💤 ±0  0 ±0 

Results for commit d899497. ± Comparison against base commit 464c82e.

@Tixxx
Copy link
Collaborator

Tixxx commented May 10, 2022

LGTM

@chongxiaoc chongxiaoc merged commit 7707267 into horovod:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Pytorch_lightning's TorchEstimator doesn't pass transformation_fn correctly
2 participants