Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HorovodVersionMismatchError subclass ImportError #3549

Merged

Conversation

amogkam
Copy link
Collaborator

@amogkam amogkam commented May 18, 2022

HorovodVersionMismatchError is raised during import horovod.torch when the current Pytorch version does not match with the torch version during Horovod installation time. Therefore, this custom error should subclass the built-in Python ImportError so that it is caught by except ImportError statements in upstream code.

Checklist before submitting

  • Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

Fixes # (issue).

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

@amogkam amogkam requested a review from chongxiaoc May 18, 2022 19:03
Copy link
Collaborator

@chongxiaoc chongxiaoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Unit Test Results

     821 files  ±0       821 suites  ±0   9h 16m 32s ⏱️ - 25m 53s
     768 tests ±0       725 ✔️ ±0       43 💤 ±0  0 ±0 
18 950 runs  ±0  13 655 ✔️ ±0  5 295 💤 ±0  0 ±0 

Results for commit 2b173cd. ± Comparison against base commit 7707267.

@github-actions
Copy link

Unit Test Results (with flaky tests)

     905 files   -   37       905 suites   - 37   9h 39m 14s ⏱️ - 35m 1s
     768 tests ±    0       725 ✔️ +    1       43 💤 ±    0  0  - 1 
21 164 runs   - 884  14 999 ✔️  - 646  6 165 💤  - 237  0  - 1 

Results for commit 2b173cd. ± Comparison against base commit 7707267.

@chongxiaoc chongxiaoc merged commit a0cd0af into horovod:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants