Add NVTX op tracing for Reducescatter, make base class destructors virtual #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
Signed-off-by: Max H. Gerlach <git@maxgerlach.de>
maxhgerlach
changed the title
Unit Test Results (with flaky tests) 975 files - 44 975 suites - 44 10h 7m 13s ⏱️ - 24m 50s For more details on these failures, see this check. Results for commit 0e863e1. ± Comparison against base commit 1b3452f. |
|
LGTM! @tgaddair @romerojosh what do you think? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before submitting
Description
In #3299 I forgot to register the
"HorovodReducescatter"string with NVTX to use it in named op ranges. This means thatReducescatterops would appear as "[Unknown]" in Nsight Systems profiles.Besides that change I've defined virtual destructors for two abstract polymorphic base classes. This should fix a warning that has been mentioned in #3541. Generally I think having them virtual is a safer practice, but currently there probably is no actual problem because smart pointers (
std::shared_ptrorstd::unique_ptr) are used rather than raw base class pointers.