Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Fix finding nvcc (if not in $PATH) with older versions of CMake #3682

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Build: Fix finding nvcc (if not in $PATH) with older versions of CMake #3682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3dca14
Fix finding nvcc (if missing in PATH) on oldish versions of CMake (li…
maxhgerlach Sep 7, 2022
48c741e
Update changelog
maxhgerlach Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- PyTorch: Fixed Reducescatter functions to raise `HorovodInternalError` rather than `RuntimeError`. ([#3594](https://github.com/horovod/horovod/pull/3594))
- PyTorch on GPUs without GPU operations: Fixed grouped allreduce to set CPU device in tensor table. ([#3594](https://github.com/horovod/horovod/pull/3594))
- Fixed race condition in PyTorch allocation handling. ([#3639](https://github.com/horovod/horovod/pull/3639))
- Build: Fixed finding nvcc (if not in $PATH) with older versions of CMake. ([#3682](https://github.com/horovod/horovod/pull/3682))


## [v0.25.0] - 2022-06-20
Expand Down
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ if(NOT CMAKE_CUDA_COMPILER)
find_package(CUDAToolkit)
if(CUDAToolkit_BIN_DIR)
message("CUDA compiler was not found in $PATH, but searching again in CUDA Toolkit binary directory")
unset(CMAKE_CUDA_COMPILER CACHE) # need to clear this from cache, else some versions of CMake go into an infinite loop
set(CMAKE_CUDA_COMPILER "${CUDAToolkit_BIN_DIR}/nvcc")
check_language(CUDA)
endif()
Expand Down