Use packaging.version instead of distutils Version classes #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njzjz
force-pushed
the
use-packaging
branch
from
7a230f0
to
438c3fd
Compare
maxhgerlach
reviewed
Sep 14, 2022
|
Thank you for the contribution @njzjz! It's good to keep the code base up to date and to clear warnings. If you feel like continuing with this and if you have the time, there are about 40 further usages of |
Resolves the following warning: /usr/local/lib/python3.10/dist-packages/horovod/tensorflow/elastic.py:28: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
njzjz
force-pushed
the
use-packaging
branch
from
2bfa8e1
to
29ad6d0
Compare
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
|
Hi @maxhgerlach, I have replaced all of Note: Per documentation distutils will be removed in Python 3.12. |
maxhgerlach
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Great work @njzjz! Let's just wait for a full run of the CI pipeline.
|
Tests are fines, only unrelated failures. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before submitting
Description
Resolves the following warning:
Review process to land