addDocumentPaymentMeanToDirectDebit() now contains $creditorReferenceID parameter

[danielmarschall]

Fixes #53

[horstoeko]

Hi @danielmarschall,

nice... :-) Since your customization is a breaking change, I would like to mark the second parameter as “optional” - something like this:

addDocumentPaymentMeanToDirectDebit(string $buyerIban, ?string $creditorReferenceID = null)

Could you kindly implement it like this?

[danielmarschall]

Fixed! Thanks for the hint

[horstoeko]

Hi @danielmarschall,

That's almost it... :-)

It should be

public function addDocumentPaymentMeanToDirectDebit(string $buyerIban, ?string $creditorReferenceID = null): ZugferdDocumentBuilder

but not

public function addDocumentPaymentMeanToDirectDebit(string $buyerIban, string $creditorReferenceID=null): ZugferdDocumentBuilder

You forgot the question mark in front of the type declaration. It is also easier to read if you insert a space before and after the =. I know I'm fussy... :-)

[danielmarschall]

Done :-)

I also introduced another change to avoid hardcoded strings for payment means. It allows people to better understand what the number means, by hovering over the constant (IDE assumed ofc). What do you think?

[horstoeko]

Hi @danielmarschall,

that looks good... Merging....